InvisibleProgrammer commented on code in PR #4690: URL: https://github.com/apache/hive/pull/4690#discussion_r1343782227
########## ql/src/test/queries/clientpositive/materialized_view_create_rewrite_4.q: ########## @@ -1,6 +1,6 @@ -- Test Incremental rebuild of materialized view with aggregate but without count(*) -- when source tables have delete operations since last rebuild. - +--! qt:replace:/(totalSize\s+)(\S+|\s+|.+)/$1#Masked#/ Review Comment: In this test, you put the replace after the explaining comments. At other tests, (e.g. at ql/src/test/queries/clientpositive/materialized_view_create_rewrite.q), before the comments. Could you please make it consistent? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org For additional commands, e-mail: gitbox-h...@hive.apache.org
