InvisibleProgrammer commented on code in PR #4690:
URL: https://github.com/apache/hive/pull/4690#discussion_r1343805305
##########
itests/hive-unit/src/test/java/org/apache/hadoop/hive/ql/txn/compactor/TestCompactor.java:
##########
@@ -398,7 +398,7 @@ public void testStatsAfterCompactionPartTbl() throws
Exception {
.getParameters();
Assert.assertEquals("The number of files is differing from the expected",
"2", parameters.get("numFiles"));
Assert.assertEquals("The number of rows is differing from the expected",
"2", parameters.get("numRows"));
- Assert.assertEquals("The total table size is differing from the expected",
"1396", parameters.get("totalSize"));
+ Assert.assertEquals("The total table size is differing from the expected",
"1395", parameters.get("totalSize"));
Review Comment:
They are changing in every single orc upgrade. Usually with about 1 bytes.
As far I remember, it is because the orc file itself contains some version
information about orc itself.
At one of the previous PRs I had the same concern about it as I see no value
on those checks. I cannot remember who answered but the answer was something
like 'Ok, but what if something goes wrong and there will be a significant
change in the size? If we don't check it, we won't know about that'.
TBH, I'm not completely on board with this answer, I'm pretty sure there are
other ways of spotting a significant change in the size of the orc files.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org
For additional commands, e-mail: gitbox-h...@hive.apache.org
