zratkai commented on code in PR #4690:
URL: https://github.com/apache/hive/pull/4690#discussion_r1343989556
##########
itests/hive-unit/src/test/java/org/apache/hadoop/hive/ql/txn/compactor/TestCrudCompactorOnTez.java:
##########
@@ -146,7 +146,7 @@ private void
testRebalanceCompactionWithParallelDeleteAsSecond(boolean optimisti
}
aborted = true;
Assert.assertEquals(e.getCause().getClass(), LockException.class);
- Assert.assertEquals(e.getCauseMessage(), "Transaction manager has
aborted the transaction txnid:21. Reason: Aborting [txnid:21,24] due to a
write conflict on default/rebalance_test committed by [txnid:20,24] d/u");
+ Assert.assertEquals( "Transaction manager has aborted the transaction
txnid:21. Reason: Aborting [txnid:21,24] due to a write conflict on
default/rebalance_test committed by [txnid:20,24] d/u", e.getCauseMessage());
Review Comment:
Since there are more comments fixing.
##########
ql/src/test/queries/clientpositive/materialized_view_create_rewrite_4.q:
##########
@@ -1,6 +1,6 @@
-- Test Incremental rebuild of materialized view with aggregate but without
count(*)
-- when source tables have delete operations since last rebuild.
-
+--! qt:replace:/(totalSize\s+)(\S+|\s+|.+)/$1#Masked#/
Review Comment:
Done.
##########
ql/src/test/queries/clientpositive/row__id.q:
##########
@@ -1,6 +1,8 @@
+--! qt:replace:/(.+)(Data size: \d+)(.+)/$1#Masked#$3/
-- tid is flaky when compute column stats
set hive.stats.column.autogather=false;
set hive.txn.manager=org.apache.hadoop.hive.ql.lockmgr.DbTxnManager;
+set hive.support.concurrency=true;
Review Comment:
Removed.
##########
ql/src/test/results/clientpositive/tez/orc_merge12.q.out:
##########
@@ -144,7 +144,7 @@ PREHOOK: Input: default@alltypesorc3xcols
PREHOOK: Output: hdfs://### HDFS PATH ###
-- BEGIN ORC FILE DUMP --
Structure for hdfs://### HDFS PATH ###
-File Version: 0.12 with ORC_14 by ORC Java 1.8.3
+File Version:#Masked#
Review Comment:
The test has nothing to do with the file version.
##########
itests/hive-unit/src/test/java/org/apache/hadoop/hive/ql/txn/compactor/TestCompactor.java:
##########
@@ -398,7 +398,7 @@ public void testStatsAfterCompactionPartTbl() throws
Exception {
.getParameters();
Assert.assertEquals("The number of files is differing from the expected",
"2", parameters.get("numFiles"));
Assert.assertEquals("The number of rows is differing from the expected",
"2", parameters.get("numRows"));
- Assert.assertEquals("The total table size is differing from the expected",
"1396", parameters.get("totalSize"));
+ Assert.assertEquals("The total table size is differing from the expected",
"1395", parameters.get("totalSize"));
Review Comment:
Deleted.
##########
standalone-metastore/pom.xml:
##########
@@ -89,7 +89,7 @@
<libthrift.version>0.16.0</libthrift.version>
<log4j2.version>2.18.0</log4j2.version>
<mockito-core.version>3.3.3</mockito-core.version>
- <orc.version>1.8.3</orc.version>
+ <orc.version>1.8.5</orc.version>
Review Comment:
The parent for standalone-metastore is not hive, so it can not inherit from
it.
<parent>
<groupId>org.apache</groupId>
<artifactId>apache</artifactId>
<version>23</version>
</parent>
##########
ql/src/test/results/clientpositive/beeline/materialized_view_create_rewrite.q.out:
##########
@@ -63,7 +63,7 @@ numFiles 1
numFilesErasureCoded 0
numRows 2
rawDataSize 408
-totalSize 474
+totalSize #Masked#
Review Comment:
I am happy you love it. :)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org
For additional commands, e-mail: gitbox-h...@hive.apache.org
