dengzhhu653 commented on code in PR #5275:
URL: https://github.com/apache/hive/pull/5275#discussion_r1719197441


##########
standalone-metastore/metastore-common/src/main/java/org/apache/hadoop/hive/metastore/HiveMetaStoreClient.java:
##########
@@ -4727,6 +4727,16 @@ public List<String> getFunctions(String catName, String 
dbName, String pattern)
     return client.get_functions(prependCatalogToDbName(catName, dbName, conf), 
pattern);
   }
 
+  @Override
+  public List<Function> getFunctionsInDb(String dbName, String pattern) throws 
TException {
+    GetFunctionsRequest request = new GetFunctionsRequest(dbName);
+    request.setCatalogName(getDefaultCatalog(conf));
+    request.setPattern(pattern);
+    request.setReturnNames(false);
+    return client.get_functions_in_db(request).getFunctions();
+//    return 
client.get_functions_in_db(prependCatalogToDbName(getDefaultCatalog(conf), 
dbName, conf), pattern);

Review Comment:
   nit: remove this comment?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org
For additional commands, e-mail: gitbox-h...@hive.apache.org

Reply via email to