dengzhhu653 commented on code in PR #5275:
URL: https://github.com/apache/hive/pull/5275#discussion_r1719202319
##########
standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/RawStore.java:
##########
@@ -1623,6 +1623,15 @@ void dropFunction(String catName, String dbName, String
funcName)
*/
List<String> getFunctions(String catName, String dbName, String pattern)
throws MetaException;
+ /**
+ * Retrieve list of function names based on name pattern.
+ * @param dbName database name
+ * @param pattern pattern to match
+ * @return functions that match the pattern
+ * @throws MetaException incorrectly specified function
+ */
+ List<Function> getFunctionsInDb(String catName, String dbName, String
pattern) throws MetaException;
Review Comment:
I was thinking how we can merge `List<String> getFunctions` and
`List<Function> getFunctionsInDb`, can we change it to ` <T> void
getFunctions(String catName, String dbName, String pattern, List<T> result)
throws MetaException;` and mark the original `getFunctions` as deprecated?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org
For additional commands, e-mail: gitbox-h...@hive.apache.org
