zratkai commented on code in PR #5433:
URL: https://github.com/apache/hive/pull/5433#discussion_r1754828814
##########
ql/src/java/org/apache/hadoop/hive/ql/exec/vector/expressions/StringGroupConcatColCol.java:
##########
@@ -320,7 +320,8 @@ public void evaluate(VectorizedRowBatch batch) throws
HiveException {
/*
* Do careful maintenance of the outputColVector.noNulls flag.
*/
-
+ // propagate not nulls flag.
Review Comment:
Above lines says:
// there are no nulls in either input vector
/*
* Do careful maintenance of the outputColVector.noNulls flag.
*/
So the else branch says there are no nulls, it seems strange to then says
noNulls = true
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
