InvisibleProgrammer commented on PR #5433:
URL: https://github.com/apache/hive/pull/5433#issuecomment-2344714397
`ColumnVector` initialises `noNulls` as true. I assume you tested it with a
sample data received from a special case of a customer.
I wonder, is there a chance that the original problem has other vector
expressions and maybe one of the previous steps sets noNulls to false.
About testing that path: There is a test in
`ql/src/test/org/apache/hadoop/hive/ql/exec/vector/expressions/TestVectorStringExpressions.java`
that looks like testing that code path: `testColConcatCol`
```java
// no nulls, not repeating
batch = makeStringBatch2In1Out();
batch.cols[0].noNulls = true;
batch.cols[1].noNulls = true;
expr.evaluate(batch);
outCol = (BytesColumnVector) batch.cols[2];
...
Assert.assertTrue(outCol.noNulls);
Assert.assertFalse(outCol.isRepeating);
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
