mdayakar commented on code in PR #5433:
URL: https://github.com/apache/hive/pull/5433#discussion_r1768132603


##########
ql/src/java/org/apache/hadoop/hive/ql/exec/vector/expressions/StringGroupConcatColCol.java:
##########
@@ -320,7 +320,8 @@ public void evaluate(VectorizedRowBatch batch) throws 
HiveException {
       /*
        * Do careful maintenance of the outputColVector.noNulls flag.
        */
-
+      // propagate not nulls flag.
+      outV.noNulls = true;

Review Comment:
   @maheshrajus this assignment was there earlier and got removed as a part of 
[HIVE-18622](https://issues.apache.org/jira/browse/HIVE-18622). Now you are 
adding it again so please check carefully why it was removed as a part of 
[HIVE-18622](https://issues.apache.org/jira/browse/HIVE-18622).



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to