maheshrajus commented on code in PR #5433:
URL: https://github.com/apache/hive/pull/5433#discussion_r1766256935
##########
ql/src/java/org/apache/hadoop/hive/ql/exec/vector/expressions/StringGroupConcatColCol.java:
##########
@@ -320,7 +320,8 @@ public void evaluate(VectorizedRowBatch batch) throws
HiveException {
/*
* Do careful maintenance of the outputColVector.noNulls flag.
*/
-
+ // propagate not nulls flag.
Review Comment:
@zratkai there are two vectors. one is input vector which contains input
strings in our case. And the second vector is output which contains the result
and flags related to nulls/not nulls. So here the case is if input vector
contains mix of NULLs and NOT NULLs then previous steps sets noNulls to
false(NULL case) and same flag carried to "else" case[NOT NULL] and we are not
setting the **outV.noNulls** flag to true.
I just modified the code to set the **outV.noNulls** flag true in else case
and i verified in cluster. Fix is working fine.
I am trying to add the qtest but i am not able to reproduce the issue
locally with q file.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
