asolimando commented on code in PR #5444:
URL: https://github.com/apache/hive/pull/5444#discussion_r1814744959
##########
standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/common/histogram/KllHistogramEstimator.java:
##########
@@ -30,11 +30,11 @@ public class KllHistogramEstimator {
private final KllFloatsSketch kll;
KllHistogramEstimator() {
- this.kll = new KllFloatsSketch();
+ this.kll = KllFloatsSketch.newHeapInstance();
Review Comment:
It's crucial to make sure backward compatibility, especially because stats
in metastore are meant to be interoperable between engines, so if we are
breaking compatibility with other engines using an older datasketch version, we
must highlight it clearly.
I suggest to just do a quick test locally, compute with 1.2, print the
quantiles, write to a file, load it with the current version and display the
same. It can be just a blank java project with a main class, you don't even
need Hive to test that, as we rely on the serde of the library.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
