deniskuzZ commented on code in PR #5613:
URL: https://github.com/apache/hive/pull/5613#discussion_r1923582358
##########
ql/src/java/org/apache/hadoop/hive/ql/exec/tez/TezTask.java:
##########
@@ -337,13 +337,14 @@ public int execute() {
&& (HiveConf.getBoolVar(conf, HiveConf.ConfVars.TEZ_EXEC_SUMMARY) ||
Utilities.isPerfOrAboveLogging(conf))) {
for (CounterGroup group : runtimeContext.counters) {
- LOG.info(group.getDisplayName() +":");
- for (TezCounter counter: group) {
- LOG.info(" "+counter.getDisplayName()+": "+counter.getValue());
+ monitor.printInfo(group.getDisplayName() + ":");
+ for (TezCounter counter : group) {
+ monitor.printInfo(" " + counter.getDisplayName() + ": " +
counter.getValue());
}
}
}
updateNumRows();
+ monitor.endSummary();
Review Comment:
not sure what it does, but maybe we should call it finally?
what if `updateNumRows` throws an exception, previously we added the LOGS
incrementally, what happens now?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
