abstractdog commented on code in PR #5613: URL: https://github.com/apache/hive/pull/5613#discussion_r1923593262
########## ql/src/java/org/apache/hadoop/hive/ql/QueryInfo.java: ########## @@ -27,9 +31,10 @@ public class QueryInfo { private final long beginTime; private final String sessionId; private final String operationId; + private final Instant beginTimeUTC; Review Comment: we need this in query history where we store start/end time in server's timezone and in utc for convenience reasons, but I can achieve it without storing it in a field, simply: ``` public Instant getBeginTimeUTC() { return Instant.ofEpochMilli(beginTime); } ``` this way maybe I can get away without the jackson dependency too -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org For additional commands, e-mail: gitbox-h...@hive.apache.org