abstractdog commented on code in PR #5613:
URL: https://github.com/apache/hive/pull/5613#discussion_r1923730527
##########
ql/src/java/org/apache/hadoop/hive/ql/DriverFactory.java:
##########
@@ -40,7 +40,7 @@ private DriverFactory() {
}
public static IDriver newDriver(HiveConf conf) {
- return newDriver(getNewQueryState(conf), null);
+ return newDriver(getNewQueryState(conf), QueryInfo.getFromConf(conf));
Review Comment:
checked, we need this
we use this method extensively, mostly in tests, without this part the
attached qtest is ruined, because query_history.start_time becomes NULL
<img width="697" alt="Screenshot 2025-01-21 at 14 23 24"
src="https://github.com/user-attachments/assets/a2b359bc-1d25-47ee-a2f6-3ae80cfce2ed";
/>
I think any codepath that worked with a null QueryInfo should work properly
with a non-null one
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org
For additional commands, e-mail: gitbox-h...@hive.apache.org
