abstractdog commented on code in PR #5613:
URL: https://github.com/apache/hive/pull/5613#discussion_r1923534667
##########
ql/src/java/org/apache/hadoop/hive/ql/Driver.java:
##########
@@ -94,7 +96,7 @@ public Driver(HiveConf conf) {
// Pass lineageState when a driver instantiates another Driver to run or
compile another query
public Driver(HiveConf conf, Context ctx, LineageState lineageState) {
- this(QueryState.getNewQueryState(conf, lineageState), null);
+ this(QueryState.getNewQueryState(conf, lineageState),
QueryInfo.getFromConf(conf));
Review Comment:
in the beginning of the implementation, I ran full precommit tests with
enabling this service by default and enabling everywhere it's possible (all
qtests for example), which led to some problems that are not visible otherwise
one of those problems were that the Driver instance can be created here with
null QueryInfo, which led to NPEs in both prod and test code (as far as I can
remember), so I decided to create an empty one here, which looks much more
valid then null (so actually, the query history service was the one that showed
QueryInfo==null can cause problems)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org
For additional commands, e-mail: gitbox-h...@hive.apache.org
