okumin commented on PR #5754:
URL: https://github.com/apache/hive/pull/5754#issuecomment-2809446019
Thanks. From my point of view, we'll have to do the following things when we
close this pull request.
- We have to include the JIRA ticket id in the PR title(= commit message)
- We have to close the linked JIRA ticket with fix version = 4.1.0
I assume this PR includes HIVE-28888, HIVE-28889 and HIVE-28893. I expect
the remaining tickets, meaning HIVE-28890, HIVE-28891, and HIVE-28892, not to
be included.
I am thinking of consolidating tickets like below, keeping 1-1 mapping
between PR and JIRA[1].
- HIVE-28887(umbrella)
- HIVE-28888 -> Consolidate with HIVE-28889 and HIVE-28893
- HIVE-28889 -> VOID
- HIVE-28890 -> (Not yet done)
- HIVE-28891 -> (Not yet done)
- HIVE-28892 -> (Not yet done)
- HIVE-28893 -> VOID
Also, I added some minor comments. I ran spot bugs on my local machine with
this change, and I've not seen any issues so far. Thanks!
- [1] I've seen the case PR : JIRA = 1 : N but I don't know when we should
accept it
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org
For additional commands, e-mail: gitbox-h...@hive.apache.org
