tanishq-chugh commented on code in PR #5754:
URL: https://github.com/apache/hive/pull/5754#discussion_r2047375232
##########
storage-api/src/java/org/apache/hive/common/util/BloomFilter.java:
##########
@@ -329,20 +331,19 @@ public static void mergeBloomFilterBytes(
* for index bounds nor expand the bit set size if the specified index is
greater than the size.
*/
static class BitSet {
- private final long[] data;
Review Comment:
Yes. This is definitely a better approach to solve this spotbug. Thanks for
the suggestion. i have made the change in
[be7e285](https://github.com/apache/hive/pull/5754/commits/be7e28519d76d024ff78ffae1a268f8fab4e1e48)
##########
storage-api/src/java/org/apache/hive/common/util/BloomKFilter.java:
##########
@@ -59,32 +60,44 @@ private static void checkArgument(boolean expression,
String message) {
}
}
- public BloomKFilter(long maxNumEntries) {
+ public BloomKFilter(int k, long m, int totalBlockCount, long[] arr) {
Review Comment:
Made it private in
[be7e285](https://github.com/apache/hive/pull/5754/commits/be7e28519d76d024ff78ffae1a268f8fab4e1e48)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
