tanishq-chugh commented on code in PR #5754:
URL: https://github.com/apache/hive/pull/5754#discussion_r2047373148
##########
storage-api/src/java/org/apache/hadoop/hive/common/ValidReadTxnList.java:
##########
@@ -59,8 +59,10 @@ public ValidReadTxnList(long[] exceptions, BitSet
abortedBits, long highWatermar
this.highWatermark = highWatermark;
}
- public ValidReadTxnList(String value) {
- readFromString(value);
+ public static ValidReadTxnList fromValue(String value) {
+ ValidReadTxnList txnList = new ValidReadTxnList();
+ txnList.readFromString(value);
+ return txnList;
Review Comment:
Yes, this change is as well to address CT_CONSTRUCTOR_THROW spotbug.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org
For additional commands, e-mail: gitbox-h...@hive.apache.org
