tanishq-chugh commented on code in PR #5754:
URL: https://github.com/apache/hive/pull/5754#discussion_r2047377331
##########
storage-api/src/java/org/apache/hive/common/util/BloomKFilter.java:
##########
@@ -397,21 +410,14 @@ public static byte[] getInitialBytes(long
expectedEntries) {
* for index bounds nor expand the bit set size if the specified index is
greater than the size.
*/
public static class BitSet {
- private final long[] data;
+ private long[] data;
Review Comment:
Yes. Made the field private as well as changed the constructor/build method
similar to your suggested change for [BloomFilter Bitset
class](https://github.com/apache/hive/pull/5754#discussion_r2046784575). Change
made in
[be7e285](https://github.com/apache/hive/pull/5754/commits/be7e28519d76d024ff78ffae1a268f8fab4e1e48)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org
For additional commands, e-mail: gitbox-h...@hive.apache.org
