tanishq-chugh commented on code in PR #5404:
URL: https://github.com/apache/hive/pull/5404#discussion_r2059898636
##########
standalone-metastore/metastore-tools/metastore-benchmarks/pom.xml:
##########
@@ -189,18 +189,12 @@
<groupId>org.apache.maven.plugins</groupId>
<artifactId>maven-compiler-plugin</artifactId>
<configuration>
- <compilerId>javac-with-errorprone</compilerId>
<forceJavacCompilerUse>true</forceJavacCompilerUse>
</configuration>
<!--
Error Prone integration
-->
<dependencies>
- <dependency>
- <groupId>org.codehaus.plexus</groupId>
- <artifactId>plexus-compiler-javac-errorprone</artifactId>
- <version>${javac.errorprone.version}</version>
- </dependency>
Review Comment:
Such plexus compiler errorprone support is no longer available starting from
jdk11+ , instead the -Xplugin:Errorprone arg is added to the compiler
configuration to compensate for the same.
Sources:
[https://github.com/google/error-prone/issues/1242](https://github.com/google/error-prone/issues/1242)
,
[https://github.com/google/error-prone/issues/535#issuecomment-414167065](https://github.com/google/error-prone/issues/535#issuecomment-414167065)
Addressed in
[1a8c107](https://github.com/apache/hive/pull/5404/commits/1a8c107f80b088ba3d73d82eb5f1dda0bb275243)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org
For additional commands, e-mail: gitbox-h...@hive.apache.org
