tanishq-chugh commented on code in PR #5404:
URL: https://github.com/apache/hive/pull/5404#discussion_r2056643810
##########
llap-server/src/test/org/apache/hadoop/hive/llap/daemon/impl/TestLlapDaemon.java:
##########
@@ -60,6 +61,18 @@ public class TestLlapDaemon {
MetricsUtils.METRICS_PROCESS_NAME
};
+ private static List<InstanceField> allDeclaredFieldsOf(Object testInstance) {
Review Comment:
Hi @deniskuzZ
Yes, this helper function has been moved to ReflectionUtils in
[8188d24](https://github.com/apache/hive/pull/5404/commits/8188d244fa4196ba8b221a47da997fa7b9e31fc3)
The name here is kept same as allDeclaredFieldsOf, which we were using
coming in from mockito-core 3.4.4 . With the mockito upgrade, the same function
is not available anymore and this helper function has been created with the
same logic which does get the fields of all the superclass to compensate for
the same. Let us know what name should be used here.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org
For additional commands, e-mail: gitbox-h...@hive.apache.org
