InvisibleProgrammer commented on code in PR #5709:
URL: https://github.com/apache/hive/pull/5709#discussion_r2056532089
##########
jdbc-handler/src/test/java/org/apache/hive/storage/jdbc/conf/TestJdbcStorageConfigManager.java:
##########
@@ -40,9 +41,9 @@ public void testWithAllRequiredSettingsDefined() throws
Exception {
JdbcStorageConfigManager.copyConfigurationToJob(props, jobMap);
assertThat(jobMap, is(notNullValue()));
- assertThat(jobMap.size(), is(equalTo(4)));
+ assertThat(jobMap.size(), is(equalTo(3)));
assertThat(jobMap.get(JdbcStorageConfig.DATABASE_TYPE.getPropertyName()),
is(equalTo("MYSQL")));
- assertThat(jobMap.get(JdbcStorageConfig.JDBC_URL.getPropertyName()),
is(equalTo("jdbc://localhost:3306/hive")));
+ assertThat(jobMap.get(JdbcStorageConfig.JDBC_URL.getPropertyName()),
is(nullValue()));
Review Comment:
It is already removing the URL. If you watch it carefully, before the
change, it checked if the proper JDBC_URL is received. Now it expects null as
it is removed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org
For additional commands, e-mail: gitbox-h...@hive.apache.org
