InvisibleProgrammer commented on code in PR #5709:
URL: https://github.com/apache/hive/pull/5709#discussion_r2062733137
##########
jdbc-handler/src/main/java/org/apache/hive/storage/jdbc/conf/JdbcStorageConfigManager.java:
##########
@@ -66,7 +68,9 @@ public static void copyConfigurationToJob(Properties props,
Map<String, String>
if (!key.equals(CONFIG_PWD) &&
!key.equals(CONFIG_PWD_KEYSTORE) &&
!key.equals(CONFIG_PWD_KEY) &&
- !key.equals(CONFIG_PWD_URI)) {
+ !key.equals(CONFIG_PWD_URI) &&
+ !key.equals(CONFIG_JDBC_USERNAME)
Review Comment:
Hi, I added a couple of extra steps around JdbcStorageHandler tables:
`ql/src/test/queries/clientpositive/explain_jdbc.q`
I couldn't make the test queries fail. And the sensitive information is
filtered out from the explains.
Could you please be specific about what cases you are thinking about?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org
For additional commands, e-mail: gitbox-h...@hive.apache.org
