deniskuzZ commented on code in PR #5709:
URL: https://github.com/apache/hive/pull/5709#discussion_r2058073762
##########
jdbc-handler/src/main/java/org/apache/hive/storage/jdbc/conf/JdbcStorageConfigManager.java:
##########
@@ -66,7 +68,9 @@ public static void copyConfigurationToJob(Properties props,
Map<String, String>
if (!key.equals(CONFIG_PWD) &&
!key.equals(CONFIG_PWD_KEYSTORE) &&
!key.equals(CONFIG_PWD_KEY) &&
- !key.equals(CONFIG_PWD_URI)) {
+ !key.equals(CONFIG_PWD_URI) &&
+ !key.equals(CONFIG_JDBC_USERNAME)
Review Comment:
I also think that would break the flow.
`password` is passed through the secrets (i.e.
`tableDesc.setJobSecrets(jobSecrets)`)
````
public void configureInputJobProperties(TableDesc tableDesc, Map<String,
String> jobProperties) {
JdbcStorageConfigManager.copyConfigurationToJob(properties,
jobProperties);
}
public void configureInputJobCredentials(TableDesc tableDesc, Map<String,
String> jobSecrets) {
JdbcStorageConfigManager.copySecretsToJob(properties, jobSecrets);
}
````
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org
For additional commands, e-mail: gitbox-h...@hive.apache.org
