deniskuzZ commented on code in PR #5709:
URL: https://github.com/apache/hive/pull/5709#discussion_r2056564357
##########
jdbc-handler/src/test/java/org/apache/hive/storage/jdbc/conf/TestJdbcStorageConfigManager.java:
##########
@@ -40,9 +41,9 @@ public void testWithAllRequiredSettingsDefined() throws
Exception {
JdbcStorageConfigManager.copyConfigurationToJob(props, jobMap);
assertThat(jobMap, is(notNullValue()));
- assertThat(jobMap.size(), is(equalTo(4)));
+ assertThat(jobMap.size(), is(equalTo(3)));
assertThat(jobMap.get(JdbcStorageConfig.DATABASE_TYPE.getPropertyName()),
is(equalTo("MYSQL")));
- assertThat(jobMap.get(JdbcStorageConfig.JDBC_URL.getPropertyName()),
is(equalTo("jdbc://localhost:3306/hive")));
+ assertThat(jobMap.get(JdbcStorageConfig.JDBC_URL.getPropertyName()),
is(nullValue()));
Review Comment:
Because your change removed it:
https://github.com/apache/hive/pull/5709/files#diff-40610d6d8ad5f0c071e86342a1d86aecd602923afb8abc9be115c5f5a1c3f401R74.
What I am saying is we shouldn't remove URL
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org
For additional commands, e-mail: gitbox-h...@hive.apache.org
