tanishq-chugh commented on code in PR #5404:
URL: https://github.com/apache/hive/pull/5404#discussion_r2062956209
##########
pom.xml:
##########
@@ -1894,6 +1910,29 @@
<artifactId>jamon-maven-plugin</artifactId>
<version>${jamon.plugin.version}</version>
</plugin>
+ <plugin>
+ <groupId>org.apache.maven.plugins</groupId>
+ <artifactId>maven-javadoc-plugin</artifactId>
+ <configuration>
+ <doclint>none</doclint>
+ <useStandardDocletOptions>false</useStandardDocletOptions>
+ <additionalDependencies>
+ <additionalDependency>
+ <groupId>io.dropwizard.metrics</groupId>
+ <artifactId>metrics-core</artifactId>
+ <version>3.1.0</version>
Review Comment:
Changed to use the existing variable for the same - `dropwizard.version`. We
need to use the same version of this dependency as being used by hive as it is
being added here just to make it available in classpath of javadoc-plugin in
its aggregation phase.
Addressed in
[5178b33](https://github.com/apache/hive/pull/5404/commits/5178b33aa637f21e85c4f7c9fcba0625e1913076)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org
For additional commands, e-mail: gitbox-h...@hive.apache.org
