tanishq-chugh commented on code in PR #5404:
URL: https://github.com/apache/hive/pull/5404#discussion_r2062984197
##########
ql/src/test/org/apache/hadoop/hive/ql/udf/generic/TestGenericUDFToUnixTimestamp.java:
##########
@@ -167,7 +167,8 @@ public void testStringArg2() throws HiveException {
runAndVerify(udf2,
new Text("1400-02-01 00:00:00 ICT"),
new Text("yyyy-MM-dd HH:mm:ss z"),
- new LongWritable(TimestampTZUtil.parse("1400-01-31 09:00:22",
ZoneId.systemDefault()).getEpochSecond()));
+ new LongWritable(TimestampTZUtil.parse("1400-01-31 09:24:58",
ZoneId.systemDefault()).getEpochSecond())); // jdk8 & jdk17
use different IANA TZdata versions resulting
Review Comment:
The query output has changed here. So, yes there is a high chance that it
will cause a regression for users.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org
For additional commands, e-mail: gitbox-h...@hive.apache.org
