difin commented on code in PR #5995:
URL: https://github.com/apache/hive/pull/5995#discussion_r2283310476
##########
iceberg/iceberg-handler/src/main/java/org/apache/iceberg/mr/hive/HiveIcebergMetaHook.java:
##########
@@ -822,7 +846,7 @@ private void
setCommonHmsTablePropertiesForIceberg(org.apache.hadoop.hive.metast
Preconditions.checkArgument(location != null, "Table location not set");
}
- Map<String, String> hmsParams = hmsTable.getParameters();
+ Map<String, String> hmsParams =
Optional.ofNullable(hmsTable.getParameters()).orElseGet(Maps::newHashMap);
Review Comment:
reverted.
##########
iceberg/iceberg-handler/src/main/java/org/apache/iceberg/mr/hive/HiveIcebergMetaHook.java:
##########
@@ -753,7 +777,7 @@ public void
preTruncateTable(org.apache.hadoop.hive.metastore.api.Table table, E
private void alterTableProperties(org.apache.hadoop.hive.metastore.api.Table
hmsTable,
Map<String, String> contextProperties) {
- Map<String, String> hmsTableParameters = hmsTable.getParameters();
+ Map<String, String> hmsTableParameters =
Optional.ofNullable(hmsTable.getParameters()).orElseGet(Maps::newHashMap);
Review Comment:
reverted.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org
For additional commands, e-mail: gitbox-h...@hive.apache.org
