difin commented on code in PR #5995:
URL: https://github.com/apache/hive/pull/5995#discussion_r2283346943
##########
iceberg/iceberg-handler/src/main/java/org/apache/iceberg/mr/hive/HiveIcebergMetaHook.java:
##########
@@ -923,15 +938,16 @@ private static PartitionSpec spec(Configuration
configuration, Schema schema,
InputFormatConfig.PARTITION_SPEC + " or already converted to a
partition transform ");
PartitionSpec spec = IcebergTableUtil.spec(configuration, schema);
+ Map<String, String> hmsParameters =
Optional.ofNullable(hmsTable.getParameters()).orElseGet(Maps::newHashMap);
if (spec != null) {
-
Preconditions.checkArgument(hmsTable.getParameters().get(InputFormatConfig.PARTITION_SPEC)
== null,
+
Preconditions.checkArgument(hmsParameters.get(InputFormatConfig.PARTITION_SPEC)
== null,
"Provide only one of the following: Hive partition transform
specification, or the " +
InputFormatConfig.PARTITION_SPEC + " property");
return spec;
}
- if (hmsTable.getParameters().get(InputFormatConfig.PARTITION_SPEC) !=
null) {
- return PartitionSpecParser.fromJson(schema,
hmsTable.getParameters().get(InputFormatConfig.PARTITION_SPEC));
+ if (hmsParameters.get(InputFormatConfig.PARTITION_SPEC) != null) {
Review Comment:
Done.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org
For additional commands, e-mail: gitbox-h...@hive.apache.org
