abstractdog commented on code in PR #6011:
URL: https://github.com/apache/hive/pull/6011#discussion_r2315638404
##########
ql/src/java/org/apache/hadoop/hive/ql/exec/tez/ReduceRecordProcessor.java:
##########
@@ -305,6 +305,19 @@ public void abort() {
} else {
LOG.info("reducer not setup yet. abort not being forwarded");
}
+ if (mergeWorkList != null) {
+ for (BaseWork redWork : mergeWorkList) {
+ ((ReduceWork) redWork).getReducer().abort();
Review Comment:
I mentioned introducing a reduceWork.abort(), what about reusing it here too?
so instead of
```
((ReduceWork) redWork).getReducer().abort();
```
maybe you can do:
```
((ReduceWork) redWork).abort();
```
so ReduceWork.abort() could take care of:
1. aborting the Operator (which is returned by getReducer)
2. aborting dummy ops
so like:
this might cover an uncovered case (not sure if it's an issue at all), which
is dummyOps field of ReduceWork instances in this mergeWorkList
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org
For additional commands, e-mail: gitbox-h...@hive.apache.org
