abstractdog commented on code in PR #6011:
URL: https://github.com/apache/hive/pull/6011#discussion_r2315532912
##########
ql/src/java/org/apache/hadoop/hive/ql/exec/tez/ReduceRecordProcessor.java:
##########
@@ -343,12 +351,10 @@ void close() {
}
try {
- if (isAborted()) {
- for (ReduceRecordSource rs : sources) {
- if (!rs.close()) {
- setAborted(false); // Preserving the old logic. Hmm...
- break;
- }
+ for (ReduceRecordSource rs : sources) {
Review Comment:
returning a boolean from close is confusing anyway without a proper method
javadoc on ReduceRecordSource.close(), please create one
as this return value is used in ReduceRecordProcessor only, I'm OK with
changing the behavior, but let's clarify it with a javadoc comment
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
