abstractdog commented on code in PR #6011:
URL: https://github.com/apache/hive/pull/6011#discussion_r2315564589
##########
ql/src/java/org/apache/hadoop/hive/ql/exec/tez/ReduceRecordProcessor.java:
##########
@@ -305,6 +305,19 @@ public void abort() {
} else {
LOG.info("reducer not setup yet. abort not being forwarded");
}
+ if (mergeWorkList != null) {
+ for (BaseWork redWork : mergeWorkList) {
+ ((ReduceWork) redWork).getReducer().abort();
+ }
+ }
+ if (reduceWork != null) {
+ List<HashTableDummyOperator> dummyOps = reduceWork.getDummyOps();
+ if (dummyOps != null) {
+ for (Operator<?> dummyOp : dummyOps) {
+ dummyOp.abort();
+ }
+ }
+ }
Review Comment:
this implementation doesn't belong here, ReduceRecordProcessor is already
overloaded, what about reduceWork.abort() and do the rest there
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org
For additional commands, e-mail: gitbox-h...@hive.apache.org
