zhengchenyu commented on code in PR #6011:
URL: https://github.com/apache/hive/pull/6011#discussion_r2297697479


##########
ql/src/java/org/apache/hadoop/hive/ql/exec/tez/ReduceRecordProcessor.java:
##########
@@ -305,6 +305,14 @@ public void abort() {
     } else {
       LOG.info("reducer not setup yet. abort not being forwarded");
     }
+    if (reduceWork != null) {

Review Comment:
   @deniskuzZ Sorry I misread it. You were referring to mergeWorkList. 
Personally, I think abort would make sense. Because I think as long as abort is 
set to true, any logic in op.close where abort is false should not be executed. 
What do you think?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org
For additional commands, e-mail: gitbox-h...@hive.apache.org

Reply via email to