soumyakanti3578 commented on code in PR #6197:
URL: https://github.com/apache/hive/pull/6197#discussion_r2662813720
##########
ql/src/java/org/apache/hadoop/hive/ql/exec/Utilities.java:
##########
@@ -5094,4 +5094,32 @@ public static String getTableOrMVSuffix(Context context,
boolean createTableOrMV
}
return suffix;
}
+
+ /**
+ * Unescape a Hive JDBC identifier, removing surrounding double quotes if
present.
+ * @param identifier the identifier to unescape
+ * @return the unescaped identifier
+ */
+ public static String unescapeHiveJdbcIdentifier(String identifier) {
+ return unescapeIdentifier(identifier, '"');
Review Comment:
I used `"` as a POC for now, but I think we just have to decide on a quoting
character for Hive. I think either `'` or `"` should be fine, but we definitely
should support just one. An MSSQL user can create a table in the backend using
`[..]`, but when creating an external Hive table, they should use the quoting
character that Hive supports. What do you think?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
