soumyakanti3578 commented on code in PR #6197:
URL: https://github.com/apache/hive/pull/6197#discussion_r2662850130
##########
ql/src/java/org/apache/hadoop/hive/ql/plan/TableDesc.java:
##########
@@ -137,7 +138,7 @@ public void setJobProperties(Map<String, String>
jobProperties) {
this.jobProperties = jobProperties;
}
- @Explain(displayName = "jobProperties", explainLevels = { Level.EXTENDED })
+ @Explain(displayName = ExplainTask.JOB_PROPERTIES, explainLevels = {
Level.EXTENDED })
Review Comment:
It's related, but tangentially :)
I think I had to add `CONFIG_USERNAME` in `JdbcStorageConfigManager.java`
to support case sensitivity for one of the backend DBs (maybe Oracle, but I
have to check). And we don't want to print usernames and passwords in the
explain plans. I removed the username from the explain plans in
`ExplainTask.java`, where I am also using the variable
`ExplainTask.JOB_PROPERTIES`.
It's better to use the variable `ExplainTask.JOB_PROPERTIES` here to avoid
bugs in the future arising from changes in the `displayName`.
Without these changes we will see username in some plans.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
