soumyakanti3578 commented on code in PR #6197:
URL: https://github.com/apache/hive/pull/6197#discussion_r2663134416
##########
jdbc-handler/src/main/java/org/apache/hive/storage/jdbc/conf/DatabaseType.java:
##########
@@ -15,14 +15,68 @@
package org.apache.hive.storage.jdbc.conf;
public enum DatabaseType {
- MYSQL,
+ // Default quote is "
H2,
DB2,
DERBY,
ORACLE,
POSTGRES,
- MSSQL,
- METASTORE,
JETHRO_DATA,
- HIVE
+ MSSQL,
+
+ // Special quote cases
+ MYSQL("`"),
+ MARIADB("`"),
+ HIVE("`"),
+
+ // METASTORE will be resolved to another type
+ METASTORE(null, null);
+
+ // Keeping start and end quote separate to allow for future DBs
+ // that may have different start and end quotes
+ private final String startQuote;
+ private final String endQuote;
Review Comment:
Sure, I can simplify this in the next commit 👍🏼
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
