soumyakanti3578 commented on code in PR #6197:
URL: https://github.com/apache/hive/pull/6197#discussion_r2663101450
##########
jdbc-handler/src/main/java/org/apache/hive/storage/jdbc/dao/GenericJdbcDatabaseAccessor.java:
##########
@@ -364,7 +366,7 @@ protected String addBoundaryToQuery(String tableName,
String sql, String partiti
Matcher m = fromPattern.matcher(sql);
Preconditions.checkArgument(m.matches());
- if (!tableName.equals(m.group(2).replaceAll("[`\"]", ""))) {
Review Comment:
I think we don't need to replace anything here as the `tableName` is already
"quoted" correctly by this point, and we expect `sql` to be correctly quoted by
the user via "hive.sql.query" or generated via calcite.
However, this might change if we conditionally quote the table name, so I
might have to revisit this after we finalize [prior
discussions](https://github.com/apache/hive/pull/6197#discussion_r2662801121).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
