comphead commented on code in PR #19716:
URL: https://github.com/apache/datafusion/pull/19716#discussion_r2687096216
##########
datafusion/physical-expr-adapter/src/schema_rewriter.rs:
##########
@@ -473,6 +477,141 @@ impl<'a> DefaultPhysicalExprAdapterRewriter<'a> {
}
}
+/// Factory for creating [`BatchAdapter`] instances to adapt record batches
Review Comment:
deprecation was not fully equal. So the mapper provided opportunities to
`map_schema` which can be replaced by `PhysicalExpeAdapter` and also
`map_batch` which is challenging(if even possible) to have with new API
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
