alamb commented on code in PR #19716:
URL: https://github.com/apache/datafusion/pull/19716#discussion_r2685857152
##########
datafusion/physical-expr-adapter/src/schema_rewriter.rs:
##########
@@ -473,6 +477,141 @@ impl<'a> DefaultPhysicalExprAdapterRewriter<'a> {
}
}
+/// Factory for creating [`BatchAdapter`] instances to adapt record batches
Review Comment:
This looks like a useful API for sure (and we hit the same thing when
upgrading to 52.0.0 internally)
It looks almost, but not quite the same, as SchemaAdapterFactor / Mapper. In
other words, the API is different than SchemaAdapterFactor but looks to me like
we could have it do the same thing.
To assist with people upgrading is there any way we can un deprecate
SchemaAdapterFactory? For example, maybe we could move `SchemaAdapterFactory`
into physical-expr-adapter and leave a reference back to the old location?
That way people who have the code that uses the old interface could continue
to do so with minimal disruption
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
