I'm running Arch Linux, Geany on GTK+3 3.24.10, glib 2.60.6 > I suggested in #2220 (comment) to provide it in another PR. Is it OK to you? Not really. It can be separate commits here but the change should be done wholesale.
> Since it's a new UI for existing functionality there shouldn't be much code > churn Maybe we aren't on the same page. In my view, the search bar simply moves the dialog contents into a bar (e.g. GtkInfoBar or something custom) and for the rest of the code it should be pretty transparent whether the bar or dialog is shown. Ideally all would be handled in the glade xml and search.c. notebook.c shouldn't be concerned too much (I remember there is the assumption that the ScintillaWidget of a GeanyDocument is a direct child in the hierarchy, that'd need to be lifted). > How to achieve this? I doubt we have a generic solution, so you have to come up with something :-) perhaps some meta-preference that isn't shown in the UI just to indicate the new-installation status. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/geany/geany/pull/2220#issuecomment-518541913
