>Not really. It can be separate commits here but the change should be done >wholesale.
Search and replace dialog and search dialog are now different dialogs. I guess search bar and replace bar and search bar could be separated as well (obviously, they can use some same functions). If it were different changes as well, we could say "Ok, we have a milestone search bar, let's close the topic and talk now about search and replace bar". >In my view, the search bar simply moves the dialog contents into a bar (e.g. >GtkInfoBar or something custom) and for the rest of the code it should be >pretty transparent whether the bar or dialog is shown. Note that there is one global search dialog and many search bars. Also, for example in search bar occurrences are marked automatically while typing. >I doubt we have a generic solution, so you have to come up with something :-) >perhaps some meta-preference that isn't shown in the UI just to indicate the >new-installation status. Do we really need to do this? Maybe some information that search bar can be switched off in preferences would be enough? -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/geany/geany/pull/2220#issuecomment-518559604
