> I really dislike italics, I think it makes things a lot harder to read, and I > don't see the need (esp. as the symbol part has a different font). We had > them before but only for the non-best match, which is IMO better. If you > wanna keep them, let's only do so for those, not for the bold entry.
I didn't really want them, I just tried to unify all the rows. And yes, I agree that the non-italics version looks better. > I find it looks crowded, making it hard to decipher quickly (thus, harder to > use): the delimitation between filename and symbol is not visible at a glance. My version was just a poor man's attempt to improve the everyting-in-a-single-text-blob version, yours is definitely better. > I don't think it's wide enough to work properly with C++. When I test it on > big projects (e.g. LibreOffice), most of the time I just get the return type > and a tad more, because there are many matches, leading to longer filename, > and namespaces in the return type making it take some room. And as mentioned > previously, as many times it's overrides, it's always the same (the only > really useful part is the FQN, which is often cut off) The disadvantage of your version is that the popup could get much bigger in some extreme cases but I think it's acceptable. (Just a shameless promotion - with my LSP plugin the clangd server seems to always return the "right" symbol based on its true visibility from the given position so no popup like that seems to be necessary.) So yeah, I definitely like how it looks like. -- Reply to this email directly or view it on GitHub: https://github.com/geany/geany/pull/3547#issuecomment-1751817257 You are receiving this because you are subscribed to this thread. Message ID: <geany/geany/pull/3547/[email protected]>
