nealrichardson commented on a change in pull request #7819:
URL: https://github.com/apache/arrow/pull/7819#discussion_r465135254



##########
File path: r/R/schema.R
##########
@@ -85,7 +85,6 @@ Schema <- R6Class("Schema",
   active = list(
     names = function() {
       out <- Schema__field_names(self)
-      # Hack: Rcpp should set the encoding
       Encoding(out) <- "UTF-8"
       out
     },

Review comment:
       If `cpp11` is doing what it claims wrt unicode, you can remove this and 
just 
   
   ```r
   names = function() Schema__field_names(self),
   ```




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to