romainfrancois commented on a change in pull request #7819:
URL: https://github.com/apache/arrow/pull/7819#discussion_r471335034
##########
File path: r/src/array_from_vector.cpp
##########
@@ -406,9 +403,12 @@ std::shared_ptr<Array>
MakeFactorArray(Rcpp::IntegerVector_ factor,
case Type::INT64:
return MakeFactorArrayImpl<arrow::Int64Type>(factor, type);
default:
- Rcpp::stop(tfm::format("Cannot convert to dictionary with index_type %s",
- dict_type.index_type()->ToString()));
+ break;
}
+
+ cpp11::stop("Cannot convert to dictionary with index_type '%s'",
+ dict_type.index_type()->ToString().c_str());
+ return nullptr;
Review comment:
Thanks.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
