nealrichardson commented on a change in pull request #7819:
URL: https://github.com/apache/arrow/pull/7819#discussion_r465136902
##########
File path: r/src/arrow_types.h
##########
@@ -17,25 +17,9 @@
#pragma once
-#include "./arrow_rcpp.h"
-
-template <typename T>
-struct NoDelete {
- inline void operator()(T* ptr) {}
-};
-
-namespace Rcpp {
+#include <cpp11/R.hpp>
-template <int RTYPE>
-inline constexpr typename Rcpp::Vector<RTYPE>::stored_type default_value() {
- return Rcpp::Vector<RTYPE>::get_na();
-}
-template <>
-inline constexpr Rbyte default_value<RAWSXP>() {
- return 0;
-}
-
-} // namespace Rcpp
+#include "./arrow_rcpp.h"
Review comment:
Rename this file?
##########
File path: r/src/arrow_rcpp.h
##########
@@ -63,124 +77,212 @@ struct ns {
static SEXP arrow;
};
+class Index {
+ public:
+ // TODO: uncomment when this is merged in cpp11:
https://github.com/r-lib/cpp11/pull/58
Review comment:
FTR it is merged
##########
File path: r/README.md
##########
@@ -149,7 +149,7 @@ For any other build/configuration challenges, see the [C++
developer
guide](https://arrow.apache.org/docs/developers/cpp/building.html) and
`vignette("install", package = "arrow")`.
-### Editing Rcpp code
+### Editing C++ code
The `arrow` package uses some customized tools on top of `Rcpp` to
Review comment:
Another Rcpp on this line
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
