save-buffer commented on code in PR #12289:
URL: https://github.com/apache/arrow/pull/12289#discussion_r859062246
##########
cpp/src/arrow/compute/exec/hash_join.cc:
##########
@@ -83,50 +85,75 @@ class HashJoinBasicImpl : public HashJoinImpl {
}
Status Init(ExecContext* ctx, JoinType join_type, bool use_sync_execution,
- size_t num_threads, HashJoinSchema* schema_mgr,
+ size_t /*num_threads*/, HashJoinSchema* schema_mgr,
std::vector<JoinKeyCmp> key_cmp, Expression filter,
OutputBatchCallback output_batch_callback,
FinishedCallback finished_callback,
- TaskScheduler::ScheduleImpl schedule_task_callback) override {
- num_threads = std::max(num_threads, static_cast<size_t>(1));
+ TaskScheduler::ScheduleImpl schedule_task_callback,
+ HashJoinImpl* pushdown_target, std::vector<int> column_map)
override {
+ // TODO(ARROW-15732)
+ // Each side of join might have an IO thread being called from.
+ // As of right now, we ignore the `num_threads` argument, so later we will
have to
+ // readd `num_threads_ = num_threads;`
Review Comment:
readd as in "add again". I can change it to "re-add"
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
