save-buffer commented on code in PR #12289:
URL: https://github.com/apache/arrow/pull/12289#discussion_r860315583
##########
cpp/src/arrow/compute/exec/hash_join_benchmark.cc:
##########
@@ -126,6 +129,22 @@ class JoinBenchmark {
join_ = *HashJoinImpl::MakeBasic();
+ HashJoinImpl* bloom_filter_pushdown_target = nullptr;
+ std::vector<int> key_input_map;
+
+ bool bloom_filter_does_not_apply_to_join =
Review Comment:
Well we benchmark to see what kind of performance impact the Bloom filter
has.
But since we currently only do early-elimination of rows, and only build on
the build side, this disqualifies some types of joins, so we check that here.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
