save-buffer commented on code in PR #12289:
URL: https://github.com/apache/arrow/pull/12289#discussion_r859064822
##########
cpp/src/arrow/compute/exec/bloom_filter.cc:
##########
@@ -114,7 +114,7 @@ Status BlockedBloomFilter::CreateEmpty(int64_t
num_rows_to_insert, MemoryPool* p
}
template <typename T>
-void BlockedBloomFilter::InsertImp(int64_t num_rows, const T* hashes) {
+NO_TSAN void BlockedBloomFilter::InsertImp(int64_t num_rows, const T* hashes) {
Review Comment:
Yes, I had to make `blocks` atomic to make TSAN go away, which we don't want
to do
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
