save-buffer commented on code in PR #12289:
URL: https://github.com/apache/arrow/pull/12289#discussion_r859086950
##########
cpp/src/arrow/compute/exec/hash_join_node.cc:
##########
@@ -571,24 +573,82 @@ class HashJoinNode : public ExecNode {
}
}
- Status StartProducing() override {
- START_SPAN(span_, std::string(kind_name()) + ":" + label(),
- {{"node.label", label()},
- {"node.detail", ToString()},
- {"node.kind", kind_name()}});
- END_SPAN_ON_FUTURE_COMPLETION(span_, finished(), this);
+ std::pair<HashJoinImpl*, std::vector<int>> GetPushdownTarget() {
Review Comment:
I only use the `pair` in one spot as far as I can tell. I just use it so
that I can use `std::tie` on whoever calls `GetPushdownTarget`. I did add a big
comment though
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
