save-buffer commented on code in PR #12289:
URL: https://github.com/apache/arrow/pull/12289#discussion_r868526933
##########
cpp/src/arrow/compute/exec/hash_join.cc:
##########
@@ -604,8 +654,84 @@ class HashJoinBasicImpl : public HashJoinImpl {
return Status::OK();
}
+ Status ApplyBloomFiltersToBatch(size_t thread_index, ExecBatch& batch) {
+ if (batch.length == 0) return Status::OK();
+ int64_t bit_vector_bytes = bit_util::BytesForBits(batch.length);
+ std::vector<uint8_t> selected(bit_vector_bytes);
+ std::vector<uint32_t> hashes(batch.length);
+ std::vector<uint8_t> bv(bit_vector_bytes);
+
+ RETURN_NOT_OK(InitLocalStateIfNeeded(thread_index));
+ // Start with full selection for the current minibatch
Review Comment:
Yes, you're right
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
