dragosmg commented on code in PR #13160:
URL: https://github.com/apache/arrow/pull/13160#discussion_r873084594
##########
r/tests/testthat/test-dplyr-funcs-datetime.R:
##########
@@ -1600,17 +1600,20 @@ test_that("`as_datetime()`", {
double_date = c(10.1, 25.2, NA)
)
- test_df %>%
- arrow_table() %>%
- mutate(
- ddate = as_datetime(date),
- dchar_date_no_tz = as_datetime(char_date),
- dchar_date_non_iso = as_datetime(char_date_non_iso, format = "%Y-%d-%m
%H:%M:%S"),
- dint_date = as_datetime(int_date, origin = "1970-01-02"),
- dintegerish_date = as_datetime(integerish_date, origin = "1970-01-02"),
- dintegerish_date2 = as_datetime(integerish_date, origin = "1970-01-01")
- ) %>%
- collect()
+ compare_dplyr_binding(
Review Comment:
I expect some tests will fail, mostly due to the discarding of the
characters before the `"_"` during the registration of the binding. If we
switch to the `"package_fun_name"` naming convention, that _should_ 🤞🏻be fine.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@arrow.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
